extensions/plugin-sentry/esbuild.config.js (1)

29-29: Log the build error before exiting for faster failure diagnosis.

At Line 29, the catch block drops error details, which makes CI/local troubleshooting harder.

🔧 Suggested improvement

-]).catch(() => process.exit(1));
+]).catch((error) => {
+  console.error(error);
+  process.exit(1);
+});

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extensions/plugin-sentry/esbuild.config.js` at line 29, The current promise
rejection handler .catch(() => process.exit(1)) discards the error; update the
catch to accept the error (e.g., .catch((err) => { /* log */ })) and log the
error before exiting (for example call console.error or the project's logger
with a clear message like "Build failed" plus err) and then call process.exit(1)
so failures are visible in CI/local runs.

extensions/plugin-sentry/src/integration.ts (1)

33-33: Prefer normalized pageload names over raw pathname.

Using window.location.pathname directly can create high-cardinality transaction names (and may carry IDs). A normalized route-style name is safer for aggregation.

♻️ Proposed refinement

+function normalizeTransactionPath(pathname: string): string {
+  return pathname
+    .replace(/\/\d+(?=\/|$)/g, "/:id")
+    .replace(
+      /\/[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}(?=\/|$)/gi,
+      "/:id",
+    );
+}
+
 export function stackflowBrowserTracingIntegration(
   options: Parameters<typeof originalBrowserTracingIntegration>[0] = {},
 ) {
@@
       if (instrumentPageLoad && initialWindowLocation) {
         startBrowserTracingPageLoadSpan(client, {
-          name: initialWindowLocation.pathname,
+          name: normalizeTransactionPath(initialWindowLocation.pathname),
           attributes: {
             [SEMANTIC_ATTRIBUTE_SENTRY_OP]: "pageload",
             [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: "auto.pageload.stackflow",
             [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: "url",
           },
         });
       }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extensions/plugin-sentry/src/integration.ts` at line 33, The code uses
initialWindowLocation.pathname for transaction/route naming which can produce
high-cardinality and leak IDs; update the usage in integration.ts to normalize
the page load name (e.g., map or sanitize initialWindowLocation.pathname via a
normalizeRoute or sanitizePath function) before assigning to the transaction
name, replacing direct references to initialWindowLocation.pathname; ensure the
normalizer strips or tokenizes dynamic segments (IDs, UUIDs, numeric params) and
returns a stable route-style string for Sentry aggregation.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

extensions/plugin-sentry/src/sentryPlugin.ts (1)

64-103: Correct implementation matching Stackflow's Effect types.

The hook implementations correctly match the Effect type definitions:

• Activity-level hooks access effect.activity
• onStepPushed/onStepReplaced correctly merge effect.step.params
• onStepPopped correctly does not access step (per Effect.ts, STEP_POPPED has no step field)

The repeated call pattern could optionally be consolidated into a single helper, but the current explicit form is clear.

♻️ Optional: Extract common tracing helper

+function traceNavigation(
+  action: NavigationAction,
+  activityName: string,
+  params: Record<string, string | undefined>,
+): void {
+  startNavigationSpan(action, activityName, params);
+  addNavigationBreadcrumb(action, activityName, params);
+}
+
 export function sentryPlugin(): StackflowPlugin {
   return () => ({
     key: "plugin-sentry",
     onPushed({ effect }) {
       const { name, params } = effect.activity;
-      startNavigationSpan("push", name, params);
-      addNavigationBreadcrumb("push", name, params);
+      traceNavigation("push", name, params);
     },
     // ... apply similarly to other hooks
   });
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extensions/plugin-sentry/src/sentryPlugin.ts` around lines 64 - 103, The
implementations in sentryPlugin correctly follow Stackflow Effect types but you
can reduce repetition by extracting a small helper inside sentryPlugin that
takes (action: string, effect: Effect) or (action: string, name: string, params:
Record) and calls startNavigationSpan and addNavigationBreadcrumb; then replace
the bodies of onPushed, onPopped, onReplaced, onStepPushed, onStepPopped, and
onStepReplaced to invoke that helper (ensure step params are merged in
onStepPushed/onStepReplaced and not accessed in onStepPopped).